Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clear method for Events #9

Merged
merged 8 commits into from
Jun 17, 2020
Merged

Clear method for Events #9

merged 8 commits into from
Jun 17, 2020

Conversation

Jmsm19
Copy link
Contributor

@Jmsm19 Jmsm19 commented Jun 15, 2020

  • Fix typing in source typescript files.
  • Add .clear() method to Events to remove stored data.

Issues it attempts to solve

#7

@Jmsm19 Jmsm19 self-assigned this Jun 15, 2020
@Jmsm19 Jmsm19 changed the title Clear action Clear method for Events Jun 15, 2020
@Jmsm19 Jmsm19 requested a review from alacret June 15, 2020 18:38
src/event.ts Outdated
* Removes all data from the Event store
*/
clear(): void {
this.value = undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.value = undefined;
this.value = null;

@Jmsm19 Jmsm19 requested a review from alacret June 16, 2020 00:53
@alacret alacret merged commit 1b0e3fa into master Jun 17, 2020
@alacret alacret deleted the clear-action branch June 17, 2020 17:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants