storage/engine: centralize specification of pebble.Options #41860
Assignees
Comments
petermattis
added a commit
to petermattis/cockroach
that referenced
this issue
Oct 29, 2019
Fixes cockroachdb#41860 Release note: None
craig bot
pushed a commit
that referenced
this issue
Oct 29, 2019
41901: storage/engine: centralize specification of pebble.Options r=petermattis a=petermattis Fixes #41860 Release note: None 41993: build: Upgrade to go 1.12.12 r=bobvawter a=bobvawter This change upgrades the go runtime to 1.12.12 in order to pick up a [security fix](golang/go#34960). Per the [checklist](build/README.md): * [X] Adjust version in Docker image * [X] Rebuild the Docker image and bump the version in builder.sh accordingly * [ ] ~Bump the version in go-version-check.sh~ (Patch release, not necessary) * [X] Bump the default installed version of Go in bootstrap-debian.sh Fixes: #41718 Release note (build change): The go runtime has been upgraded to 1.12.12. Co-authored-by: Peter Mattis <petermattis@gmail.com> Co-authored-by: Bob Vawter <bob@cockroachlabs.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
The
pebble.Optionsused by CRDB are currently specified in two places:server/config.goandstorage/engine/bench_pebble_test.go. The former is used by the cockroach process and the latter by benchmarks. We also specify the comparer and merger instorage/engine/pebble.go. And #41854 adds support for specifying the table property collectors. As cleanup, we should centralize where the Pebble options are specified tostorage/engine/pebble.goto ensure we're using the same options everywhere.The text was updated successfully, but these errors were encountered: