Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[DNM] go.mod: bump grpc to 1.39.0 to test data race fix #68197

Closed
wants to merge 1 commit into from

Conversation

adityamaru
Copy link
Contributor

Testing grpc/grpc-go#4627.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
Copy link
Contributor Author

adityamaru commented Jul 28, 2021

cc: @knz

Without the patch, we see a DATA RACE immediately.
Screen Shot 2021-07-28 at 3 23 22 PM

With the patch I've gone ~7000 runs without failure:
Screen Shot 2021-07-28 at 3 21 39 PM

@knz
Copy link
Contributor

knz commented Jul 29, 2021

thank you!

@adityamaru adityamaru closed this Aug 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants