Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix CI. Bugfixes for splice and replace #46

Merged
merged 6 commits into from
Dec 5, 2019
Merged

Fix CI. Bugfixes for splice and replace #46

merged 6 commits into from
Dec 5, 2019

Conversation

nreynis
Copy link
Contributor

@nreynis nreynis commented Nov 29, 2019

  • CI: apply fixes from StyleCI,
  • Bugfix: splice on edge cases,
  • Bugfix: replace on a Chain,
  • CI: update scrutinizer,
  • CI: fix appveyor build

@nreynis
Copy link
Contributor Author

nreynis commented Nov 29, 2019

You can see the expected behaviours for array_splice on edge cases here:
https://repl.it/repls/WeakSteelblueTrials

@florianeckerstorfer florianeckerstorfer merged commit a30137e into cocur:master Dec 5, 2019
@florianeckerstorfer
Copy link
Member

Awesome, thank you for the PR

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@florianeckerstorfer florianeckerstorfer florianeckerstorfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nreynis @florianeckerstorfer