Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/add rabbitmq consumer timeout and fix http proxy support for django #3455

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dtuantran
Copy link
Collaborator

@dtuantran dtuantran commented Dec 21, 2023

@Didayolo or @bbearce or @ihsan

Add consumer_timeout into rabbitmq config in order to overwrite default value. Add http proxy support for codalab

A checklist for hand testing

  • recreate Codalab with no WORKER_CONNECTION_TIMEOUT value in .env (without variables of HTTP_PROXY, HTTPS_PROXY, NO_PROXY)
  • recreate Codalab with a WORKER_CONNECTION_TIMEOUT value in .env (without variables of HTTP_PROXY, HTTPS_PROXY, NO_PROXY)
  • recreate Codalab with HTTP_PROXY, HTTPS_PROXY and NO_PROXY variables (already done on production)

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6901945) 60.38% compared to head (4689e35) 60.38%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3455   +/-   ##
========================================
  Coverage    60.38%   60.38%           
========================================
  Files          173      173           
  Lines        11411    11411           
========================================
  Hits          6891     6891           
  Misses        4520     4520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtuantran
Copy link
Collaborator Author

If you are running Docker 5.20, you need to upgrade to 5.24 in order to run apply this changes.

@Didayolo
Copy link
Member

Shouldn't this come with changes in docker-compose.yml, so the containers access the new environment variables HTTP_PROXY and HTTPS_PROXY?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants