Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update initializer modifier to prevent reentrancy during initialization #227

Open
code423n4 opened this issue Apr 13, 2022 · 2 comments · Fixed by jpegd/core#11
Open

Update initializer modifier to prevent reentrancy during initialization #227

code423n4 opened this issue Apr 13, 2022 · 2 comments · Fixed by jpegd/core#11
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-04-jpegd/blob/main/package.json#L18-L19

Vulnerability details

Impact

The solution uses:

    "@openzeppelin/contracts": "^4.0.0",
    "@openzeppelin/contracts-upgradeable": "^4.3.2",

These dependencies have a known high severity vulnerability:

Which makes these contracts vulnerable:

contracts/helpers/CryptoPunksHelper.sol:
  19:     function initialize(address punksAddress) external initializer {

contracts/helpers/EtherRocksHelper.sol:
  19:     function initialize(address rocksAddress) external initializer {

contracts/staking/JPEGStaking.sol:
  21:     function initialize(IERC20Upgradeable _jpeg) external initializer {

contracts/vaults/FungibleAssetVaultForDAO.sol:
  71:     ) external initializer {

contracts/vaults/NFTVault.sol:
  149:     ) external initializer {

Recommended Mitigation Steps

Upgrade @openzeppelin/contracts and @openzeppelin/contracts-upgradeable to version 4.4.1 or higher.
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working labels Apr 13, 2022
code423n4 added a commit that referenced this issue Apr 13, 2022
@code423n4
Dravee issue #227
cbbeed9
@spaghettieth spaghettieth added disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") labels Apr 14, 2022
@spaghettieth spaghettieth mentioned this issue Apr 14, 2022
Merged
@spaghettieth
Copy link
Collaborator

Fixed in jpegd/core#11

@spaghettieth spaghettieth reopened this Apr 20, 2022
@spaghettieth
Copy link
Collaborator

Closed by mistake.

@spaghettieth spaghettieth added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Apr 20, 2022
@code423n4 code423n4 mentioned this issue Aug 27, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated openzeppelin dependencies and changed pragma and sol version to 0.8.4 jpegd/core
2 participants
@spaghettieth @code423n4