Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Upgraded Q -> M from 74 [1654474712630] #336

Closed
code423n4 opened this issue Jun 6, 2022 · 1 comment
Closed

Upgraded Q -> M from 74 [1654474712630] #336

code423n4 opened this issue Jun 6, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge

Comments

@code423n4
Copy link
Contributor

code423n4 commented Jun 6, 2022 •
edited by HardlyDifficult
Loading

Judge has assessed an item in Issue #74 as Medium risk. The relevant finding follows:

Use of transferFrom instead of safeTransferFrom
Cally.sol#L295

When buyers exercise the transferFrom function is used instead of safeTransferFrom. In the very unlikely event the receiving contract is somehow not aware of incoming ERC721, the token could be locked.

Consider exchanging transferFrom for safeTransferFrom
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working upgraded by judge labels Jun 6, 2022
code423n4 added a commit that referenced this issue Jun 6, 2022
@code423n4
Upgrade for hake issue #336
d0d1ba8
@HardlyDifficult
Copy link
Collaborator

Dupe of #38

@HardlyDifficult HardlyDifficult added the duplicate This issue or pull request already exists label Jun 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists upgraded by judge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HardlyDifficult @code423n4