Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use safeTransferFrom() when transferring ERC721 tokens #230

Closed
code423n4 opened this issue Sep 12, 2022 · 1 comment
Closed

Use safeTransferFrom() when transferring ERC721 tokens #230

code423n4 opened this issue Sep 12, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists invalid This doesn't seem right

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-09-nouns-builder/blob/main/src/auction/Auction.sol#L192

Vulnerability details

Impact

It's generally recommended to use safeTransferFrom() to not send tokens to an address that can't handle them.

Here's the same issue from another contest: code-423n4/2022-05-cally-findings#38

Proof of Concept

https://github.com/code-423n4/2022-09-nouns-builder/blob/main/src/auction/Auction.sol#L192

Tools Used

none

Recommended Mitigation Steps

Use the contract's safeTransferFrom() funtion
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Sep 12, 2022
code423n4 added a commit that referenced this issue Sep 12, 2022
@code423n4
Ruhum issue #230
dedb701
@GalloDaSballo
Copy link
Collaborator

Dup of #356

@GalloDaSballo GalloDaSballo added duplicate This issue or pull request already exists invalid This doesn't seem right labels Sep 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GalloDaSballo @code423n4