Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

<meta> data global variables? #1763

Open
ImprovedTube opened this issue Sep 12, 2023 · 0 comments
Open

<meta> data global variables? #1763

ImprovedTube opened this issue Sep 12, 2023 · 0 comments
Labels
data compare: https://github.com/LuanRT/YouTube.js & maybe github.com/MarcGuiselin/youtube-refined good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 12, 2023

  • the variables should be available globally in our code, for various future features /enhancements

<meta>-tags data stays the same, when the next video starts in the same tab.

so we get it from an invidious node at need to decide the playback speed feature

//The following infos will enable awesome, smart features. Some of which everyone should use.

whole 'META' is a bad way of going about it, we are comparing 11000 times for something instead of using

document.getElementsByTagName('meta').title.getAttribute("content")
document.querySelector('meta[itemprop=genre]').content

once when applicable, etc.

why? hi @raszpl


.

(btw, music detection from speed-watching exclusions can be used too here )

@ImprovedTube ImprovedTube added Bug Bug or required update after YouTube changes Feature request Wish or idea help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ data compare: https://github.com/LuanRT/YouTube.js & maybe github.com/MarcGuiselin/youtube-refined labels Sep 12, 2023
ImprovedTube added a commit that referenced this issue Nov 24, 2023
@ImprovedTube ImprovedTube added Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. and removed Bug Bug or required update after YouTube changes Feature request Wish or idea labels Jan 5, 2024
ImprovedTube added a commit that referenced this issue Jan 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
data compare: https://github.com/LuanRT/YouTube.js & maybe github.com/MarcGuiselin/youtube-refined good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

1 participant