Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

unmangle/cleanup/simplifying. Ready. #2256

Merged
merged 7 commits into from
May 9, 2024
Merged

unmangle/cleanup/simplifying. Ready. #2256

merged 7 commits into from
May 9, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented May 9, 2024

No description provided.

@raszpl raszpl changed the title Update skeleton.js unmangle Update skeleton.js unmangle/cleanup/simplifying. Ready. May 9, 2024
@raszpl raszpl changed the title Update skeleton.js unmangle/cleanup/simplifying. Ready. unmangle/cleanup/simplifying. Ready. May 9, 2024
@ImprovedTube ImprovedTube merged commit b1b9a41 into code-charity:master May 9, 2024
@ImprovedTube
Copy link
Member

wouldn't it be nice if settings.js, if it is a GUI template, came almost minified, with similar scroll height as the GUI and strategically placed/manual line breaks or indentation only? (While IDE's could display it the same as now by and intentional/manual line breaks could remain displayed marked up then.)
At least (,said before,) i don't understand why IDEs dont actually support JSON & XML, which could rather be displayed as tree-shaped-spreadsheet-fields.

@ImprovedTube
Copy link
Member

const included = ['switch', 'select', 'slider', 'shortcut', 'radio', 'color-picker', 'label', 'button'],

Btw, semantically search is missing pathes like Appearance > Details > Buttons (below the player)
& section titles like:

component: 'section',
variant: 'card',
title: 'watchedVideos',

#1935 (comment)

@raszpl
Copy link
Contributor Author

raszpl commented May 10, 2024

wouldn't it be nice if settings.js, if it is a GUI template, came almost minified

no :) minify is what you do in the deploy phase when make scripts are packaging for release

with similar scroll height as the GUI and strategically placed/manual line breaks or indentation only? (While IDE's could display it the same as now by and intentional/manual line breaks could remain displayed marked up then.) At least (,said before,) i don't understand why IDEs dont actually support JSON & XML, which could rather be displayed as tree-shaped-spreadsheet-fields.

Why would you want unreadable mess in source files? Most IDEs support auto formatting packed JSON. For example Ctrl Alt L in pychrm.

Btw, semantically search is missing pathes like Appearance > Details > Buttons (below the player)

Ill look into that

& section titles like:

component: 'section',
variant: 'card',
title: 'watchedVideos',

this is a section, cant include that, otherwise searching player would display whole contents of player section, search "watched" and you get all three entries

@raszpl raszpl deleted the patch-1 branch May 10, 2024 17:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants