Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add horizontal center prop #58

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Add horizontal center prop #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/mini-editor/src/code.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ type CodeProps = {
minColumns: number
minZoom: number
maxZoom: number
horizontalCenter: boolean
}

export function Code({
Expand All @@ -31,6 +32,7 @@ export function Code({
minColumns,
minZoom,
maxZoom,
horizontalCenter,
}: CodeProps) {
const {
prevLines,
Expand Down Expand Up @@ -62,7 +64,6 @@ export function Code({
<code>
{dimensions ? (
<SmoothLines
center={false}
progress={progress}
containerWidth={dimensions.width}
containerHeight={dimensions.height}
Expand All @@ -81,6 +82,7 @@ export function Code({
nextFocus={nextFocusIndexes}
minZoom={minZoom}
maxZoom={maxZoom}
center={horizontalCenter}
/>
) : (
<>
Expand Down
6 changes: 6 additions & 0 deletions packages/mini-editor/src/mini-editor-hike.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export type MiniEditorHikeProps = {
minZoom?: number
maxZoom?: number
button?: React.ReactNode
horizontalCenter?: boolean
classes?: Classes
} & React.PropsWithoutRef<JSX.IntrinsicElements["div"]>

Expand All @@ -51,6 +52,7 @@ function MiniEditorHike(props: MiniEditorHikeProps) {
minZoom = 0.2,
maxZoom = 1,
height,
horizontalCenter = false,
...rest
} = props
const { steps, files, stepsByFile } = useSteps(ogSteps, {
Expand Down Expand Up @@ -107,6 +109,7 @@ function MiniEditorHike(props: MiniEditorHikeProps) {
minColumns={minColumns}
minZoom={minZoom}
maxZoom={maxZoom}
horizontalCenter={horizontalCenter}
/>
)}
</EditorFrame>
Expand Down Expand Up @@ -163,6 +166,7 @@ type ContentProps = {
minColumns: number
minZoom: number
maxZoom: number
horizontalCenter: boolean
}

function EditorContent({
Expand All @@ -173,6 +177,7 @@ function EditorContent({
minColumns,
minZoom,
maxZoom,
horizontalCenter,
}: ContentProps) {
const fwdTransitions = useForwardTransitions(steps)
const bwdTransitions = useBackwardTransitions(steps)
Expand Down Expand Up @@ -200,6 +205,7 @@ function EditorContent({
minColumns={minColumns}
minZoom={minZoom}
maxZoom={maxZoom}
horizontalCenter={horizontalCenter}
/>
)
}
Expand Down
5 changes: 4 additions & 1 deletion packages/smooth-lines/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,10 @@ function getContentProps({
)

const dx = horizontalCenter
? containerWidth / 2 - (lineWidth * zoom) / 2
? Math.max(
containerWidth / 2 - (lineWidth * zoom) / 2,
0
)
: 0

return [
Expand Down
1 change: 1 addition & 0 deletions packages/storybook/src/mini-editor-hike.story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ console.log(1)`
backward={backward}
minColumns={10}
minZoom={1}
horizontalCenter={true}
/>
)}
</WithProgress>
Expand Down