Skip to content

[CM-1193] Add swift lint support #37

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2023
Merged

[CM-1193] Add swift lint support #37

merged 2 commits into from
Feb 28, 2023

Conversation

osugikoji
Copy link
Contributor

@osugikoji osugikoji commented Feb 27, 2023 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Add swift lint on the iOS sample

💡 Motivation and Context

To maintain code standards and follow YML lint conventions

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • All linters passing
  • There are no code climate issues

@osugikoji osugikoji self-assigned this Feb 27, 2023
@osugikoji osugikoji changed the title Style/add swift lint [CM-1193] Add swift lint support Feb 27, 2023
mpospese
mpospese approved these changes Feb 28, 2023
View reviewed changes
Copy link

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@osugikoji osugikoji merged commit 6592a70 into main Feb 28, 2023
@osugikoji osugikoji deleted the style/add-swift-lint branch February 28, 2023 21:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mpospese mpospese mpospese approved these changes

@kikoso kikoso Awaiting requested review from kikoso

@renatoarg renatoarg Awaiting requested review from renatoarg

Assignees

@osugikoji osugikoji

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osugikoji @mpospese