Skip to content

Add check for "isLoading" before update UI with "Typing..." animation #46

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

renatoarg
Copy link
Contributor

@renatoarg renatoarg commented Mar 6, 2023

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Check if the completion "isLoading" before update UI with "Typing..." animation.

💡 Motivation and Context

UI bug -> https://ymedialabs.atlassian.net/browse/CM-1216

💚 How did you test it?

There are no steps to reproduce this issue. It happens randomly. The best way to try to reproduce it making multiple completion requests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • All linters passing
  • There are no code climate issues

🔮 Next steps

📸 Screenshots / GIFs

@renatoarg renatoarg requested review from kikoso and osugikoji March 6, 2023 14:41
@renatoarg renatoarg self-assigned this Mar 6, 2023
@kikoso
Copy link
Contributor

kikoso commented Mar 6, 2023

Looks good!

@renatoarg renatoarg merged commit 91a1cea into main Mar 6, 2023
@kikoso kikoso deleted the jira/CM-1216/android-typing-bug branch June 7, 2023 16:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants