Skip to content

fix: AppiumTestDistribution/appium-device-farm requires 'platformName' #3950

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

rock-tran
Copy link
Contributor

Motivation/Description of the PR

  • Description of this PR, which problem it solves

I'm trying to run tests with Appium + it's plugin DeviceFarm.
At the start, the plugin raises the error then I realize it requires the 'platformName' in the capabilities.
I know I may update such plugins ( include AppiumDashboard) but that key is used so many places.
Send duplicated capabilities is easier way to fix it.

  • Resolves #issueId (if applicable).

Applicable helpers:

  • Appium

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • [] 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
Copy link
Collaborator

I guess this one just clone more key values, and won't break anything. Thanks @rock-tran

@kobenguyent kobenguyent merged commit e590213 into codeceptjs:3.x Oct 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants