Skip to content

fix(webApi): error message of dontSeeCookie #4357

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 29, 2024

Conversation

a-stankevich
Copy link
Contributor

@a-stankevich a-stankevich commented May 21, 2024

Motivation/Description of the PR

  • Description of this PR, which problem it solves
    The error message reported for 'dontSeeCookie' was copy-pasted from 'seeCookie', while it should be the opposite.
    The only helper with correct message is TestCafe, so wording from there is applied to other helpers.
  • Resolves #issueId (if applicable).

Applicable helpers:

  • Nightmare
  • Playwright
  • Puppeteer
  • WebDriver

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent changed the title Fixed error message for dontSeeCookie() fix: error message of dontSeeCookie May 21, 2024
@kobenguyent
Copy link
Collaborator

kobenguyent commented May 21, 2024

I'm not sure if we should have this change. As the error message is from here already indicated not.

err.params.type = `not ${err.params.type}`;

@a-stankevich
Copy link
Contributor Author

hm, what would be the best way to have the correct error message then? currently it's like this:
image

@a-stankevich
Copy link
Contributor Author

Oh, I think I understand.
I've removed 'not' where negate is used

@kobenguyent
Copy link
Collaborator

@a-stankevich I saw you also mentioned WebDriver, but don't see the changes there. May you check?

@a-stankevich
Copy link
Contributor Author

@a-stankevich I saw you also mentioned WebDriver, but don't see the changes there. May you check?

Those changes were done by mistake and have been reverted. I've unchecked related checkboxes now

@kobenguyent kobenguyent changed the title fix: error message of dontSeeCookie fix(webApi): error message of dontSeeCookie May 29, 2024
@kobenguyent kobenguyent merged commit e715970 into codeceptjs:3.x May 29, 2024
12 of 13 checks passed
kobenguyent added a commit that referenced this pull request Jun 7, 2024
* fix(webApi): error message of dontSeeCookie (#4357)

* Fixed error message for dontSeeCookie()

* fix(cli): gherkin command init with TypeScript (#4366)

* DOC: Update contributor faces

* fix(doc): Expect helper is not described correctly (#4370)

* fix: Puppeteer helper doc typo (#4369)

* chore(deps): bump devtools from 8.36.1 to 8.38.0 (#4374)

* chore(deps-dev): bump playwright from 1.44.0 to 1.44.1 (#4376)

Bumps [playwright](https://github.com/microsoft/playwright) from 1.44.0 to 1.44.1.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.44.0...v1.44.1)

---
updated-dependencies:
- dependency-name: playwright
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump axios from 1.6.7 to 1.7.2 (#4372)

* chore(deps-dev): bump typedoc-plugin-markdown from 3.17.1 to 4.0.3 (#4373)

* fix: handle throw error inside retryTo promise

* fix: test due to update on retryTo plugin

* fix: add a test case succeed after 2 retry

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Arthur Stankevich <a-stankevich@users.noreply.github.com>
Co-authored-by: Ando NARY <36852616+andonary@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: KobeN <7845001+kobenguyent@users.noreply.github.com>
Co-authored-by: Yoann Fleury <yoann.fleury@yahoo.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kobenguyent kobenguyent mentioned this pull request Jun 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants