Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: screenshot error in beforeSuite/AfterSuite #4385

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Jun 7, 2024

Motivation/Description of the PR

  • fix: screenshot error in beforeSuite/AfterSuite
  • fix one more scenario
     Cannot read properties of undefined (reading 'toString')
      at persistStep (node_modules/codeceptjs/lib/plugin/stepByStepReport.js:148:63)
      at /Users/t/Desktop/projects/codeceptjs-playwright-fun/node_modules/codeceptjs/lib/plugin/stepByStepReport.js:105:59
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

Applicable plugins:

  • screenshotOnFail
  • stepByStepReport

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent merged commit 1040494 into 3.x Jun 8, 2024
13 checks passed
@kobenguyent kobenguyent deleted the fix/screenshot-error-with-beforesuite-aftersuite branch June 8, 2024 04:56
@kobenguyent kobenguyent mentioned this pull request Jun 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant