-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove dependency to devtools #4563
Remove dependency to devtools #4563
Conversation
@kobenguyent - maybe you have an idea of the failing tests? |
hi @thomashohn I reckoned you removed the devtools protocol but still calling this https://github.com/codeceptjs/CodeceptJS/pull/4563/files#diff-06a1e9f6d0b95cc16170ad023c4131c7d35c145e9c6375e492ab48a8b2fa10e4R646 I'd think that causes the issue. Also please check the impact of this removal as this may cause many issues related to this change. |
I guess I was uncertain what should happen to methods using |
If I'm not wrong, Those methods use the devtools protocol as well. Initially, you could refer to this PR which introduces devtools #4105 |
@kobenguyent - so Tests are green, removed the requirement to devtools and updated to latest webdriverio on v8 - there might be some documentation that needs adoptions? |
Oh great! Thanks for your hard work! regarding docs, just edit the jsdocs, then run |
Yes - I was more unsure what to update exactly ;-) And the command seems to update a lot more than I changed ,,, |
https://github.com/codeceptjs/CodeceptJS/blob/3.x/package.json#L93 perhaps we need to remove this as well. |
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs
)npm run lint
)npm test
)