Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(cli): missing failure counts when there is failedHooks #4633

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(cli): missing failure counts when there is failedHooks #4633

merged 1 commit into from
Dec 11, 2024

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Dec 11, 2024 •
edited
Loading

Motivation/Description of the PR

  • Failure count is wrong calculated when there is failed hook.

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
Copy link
Collaborator Author

@mirao if you have some time, please give it a try with codeceptjs@3.6.10-beta.1. Thanks!

@kobenguyent kobenguyent merged commit 3e6415c into 3.x Dec 11, 2024
12 checks passed
@kobenguyent kobenguyent deleted the fix-wrong-failed-stats-count branch December 11, 2024 09:35
@kobenguyent kobenguyent mentioned this pull request Dec 11, 2024
Merged
@mirao
Copy link
Contributor

mirao commented Dec 13, 2024 •
edited
Loading

@kobenguyent I'm sorry for a delay. Just tried it with the 3.6.10 stable and it works well.

Tested with:

  • failed hooks + failed scenarios
  • failed scenarios only
  • failed hooks only
  • passed everything

Thank you very much.

@mirao mirao mentioned this pull request Dec 13, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobenguyent @mirao