-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: glob backward compatibility #4775
Conversation
published as codeceptjs@3.7.0-beta.7 for testing. |
I'm not sure if we use it correctly: In 10-11 our https://github.com/isaacs/node-glob/blob/main/changelog.md#1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test this notation, but we need to ensure we use compatible glob version
Also I'm concerned that we can actually use glob from v11 because of no named exports
Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com>
@kobenguyent please change the notation where glob is used so instead of const glob = require('glob') we would have const { globSync } = require('glob') as it is recommended now in docs I checked it works on 9 and 11 version |
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs
)npm run lint
)npm test
)