Fix fingerprint bug - don't use num occurrences #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the number of occurrences of duplicated code as a unique identifier of the issue makes the fingerprint non-deterministic with respect to a given issue at a site of the duplicated code. Opting to use checkname instead.
|
LGTM |
ABaldwinHunter
pushed a commit
that referenced
this pull request
Jan 29, 2016
Fix fingerprint bug - don't use num occurrences
| @@ -86,7 +86,7 @@ def fingerprint | |||
| digest << "-" | |||
| digest << current_sexp.mass.to_s | |||
| digest << "-" | |||
| digest << occurrences.to_s | |||
| digest << check_name | |||
There was a problem hiding this comment.
Classic also uses the type of the sexp's root node, I think. That's an extra piece of info to make the fingerprint more unique that may be worth adding.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the number of occurrences of duplicated code as a unique
identifier of the issue makes the fingerprint non-deterministic
with respect to a given issue at a site of the duplicated code.
Opting to use checkname instead.
Fixes false positives in PR comparisons: https://codeclimate.com/repos/569fa9e70c40f068790031e2/pull/3#duplication
cc @codeclimate/review