-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
QUA-948: Support .NET DotCover coverage reporting #508
Conversation
cmd/format-coverage.go
Outdated
@@ -52,6 +53,7 @@ var formatterMap = map[string]formatters.Formatter{ | |||
"lcov-json": &lcovjson.Formatter{}, | |||
"simplecov": &simplecov.Formatter{}, | |||
"xccov": &xccov.Formatter{}, | |||
"dotcover": &dotcover.Formatter{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got formatted a little weird. Do we run gofmt
against this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, codeclimate
is now set up on this repo 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Thanks for adding the integration tests. The only comment I might have about this would be: could this package and the clover
package share any code? They seem relatively similar, though I wouldn't call it a blocker since we don't find ourselves adding formatters on a regular basis.
Code Climate has analyzed commit 93a904d and detected 0 issues on this pull request. View more on Code Climate. |
Thanks for the review @larkinscott! Adding I'll try to refactor that, if possible, but I want to do it on a new PR, for clarity and to unblock this release for the customer asking for .NET support |
This PR adds support for uploading coverage reports generated by DotCover. The report is expected to be located at the project root folder, and it must be named
dotcover.xml
Please note that the
ReportType
should beDetailedXML
as it's the only format that prints coverage line by line.An example repo was uploaded here https://github.com/codeclimate/dot-net-coverage-test, and you can generate a test coverage report by running