Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Commit

Permalink
Run Python coverage tool with shell=False
Browse files Browse the repository at this point in the history
  • Loading branch information
takluyver authored Jun 3, 2019
1 parent 8660351 commit 39331a6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions codecov/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ def check_output(cmd, **popen_args):
return output.decode('utf-8')


def try_to_run(cmd):
def try_to_run(cmd, shell=True):
try:
return check_output(cmd, shell=True)
return check_output(cmd, shell=shell)
except subprocess.CalledProcessError as e:
write(' Error running `%s`: %s' % (cmd, str(getattr(e, 'output', str(e)))))

Expand All @@ -193,10 +193,10 @@ def run_python_coverage(args):
import coverage
except ImportError:
# Coverage is not installed on this Python. Hope it's on PATH.
try_to_run(['coverage'] + args)
try_to_run(['coverage'] + args, shell=False)
else:
# Coverage is installed on this Python. Run it as a module.
try_to_run([sys.executable, '-m', 'coverage'] + args)
try_to_run([sys.executable, '-m', 'coverage'] + args, shell=False)

def remove_non_ascii(data):
try:
Expand Down

0 comments on commit 39331a6

Please # to comment.