Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Cast bundle stats size to int #118

Merged
merged 2 commits into from
Feb 6, 2024
Merged

fix: Cast bundle stats size to int #118

merged 2 commits into from
Feb 6, 2024

Conversation

JerrySentry
Copy link
Contributor

Handle decimal values in size

codecov/engineering-team#1140

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@JerrySentry JerrySentry marked this pull request as ready for review February 5, 2024 21:27
Copy link

codecov-public-qa bot commented Feb 5, 2024

Codecov Report

Merging #118 (b60597b) into main (7b98010) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files         115      115           
  Lines        9392     9392           
  Branches     1499     1499           
=======================================
  Hits         8408     8408           
  Misses        781      781           
  Partials      203      203           
Flag Coverage Δ
python3.10 88.71% <100.00%> (ø)
python3.11 88.71% <100.00%> (ø)
python3.12 88.71% <100.00%> (ø)
python3.8 88.80% <100.00%> (ø)
python3.9 89.06% <100.00%> (ø)
rust 90.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
shared/bundle_analysis/parser.py 100.00% <100.00%> (ø)

Impacted file tree graph

@codecov-qa
Copy link

codecov-qa bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b98010) 89.52% compared to head (b60597b) 89.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files         115      115           
  Lines        9392     9392           
  Branches     1499     1499           
=======================================
  Hits         8408     8408           
  Misses        781      781           
  Partials      203      203           
Flag Coverage Δ
python3.10 88.71% <100.00%> (ø)
python3.11 88.71% <100.00%> (ø)
python3.12 88.71% <100.00%> (ø)
python3.8 88.80% <100.00%> (ø)
python3.9 89.06% <100.00%> (ø)
rust 90.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b98010) 91.54% compared to head (b60597b) 91.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         122      122           
  Lines        9413     9413           
  Branches     1613     1613           
=======================================
  Hits         8617     8617           
  Misses        781      781           
  Partials       15       15           
Flag Coverage Δ
python3.10 88.71% <100.00%> (ø)
python3.11 88.71% <100.00%> (ø)
python3.12 88.71% <100.00%> (ø)
python3.8 88.80% <100.00%> (ø)
python3.9 89.06% <100.00%> (ø)
rust 90.20% <ø> (ø)
smart-labels 91.70% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JerrySentry JerrySentry merged commit aca1191 into main Feb 6, 2024
26 checks passed
@JerrySentry JerrySentry deleted the api_1139 branch February 6, 2024 13:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants