Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: rename save_commit_measurements task by prepending timeseries to it #122

Merged

Conversation

adrian-codecov
Copy link
Contributor

I'm renaming this task to prepend timeseries to better adhere with naming conventions and let it be in the same queue configuration for timeseries.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1afb5ad) 89.52% compared to head (d8d875d) 89.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   89.52%   89.52%   -0.01%     
==========================================
  Files         115      115              
  Lines        9394     9393       -1     
  Branches     1499     1499              
==========================================
- Hits         8410     8409       -1     
  Misses        781      781              
  Partials      203      203              
Flag Coverage Δ
python3.10 88.71% <100.00%> (-0.01%) ⬇️
python3.11 88.71% <100.00%> (-0.01%) ⬇️
python3.12 88.71% <100.00%> (-0.01%) ⬇️
python3.8 88.80% <100.00%> (-0.01%) ⬇️
python3.9 89.06% <100.00%> (-0.01%) ⬇️
rust 90.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1afb5ad) 89.52% compared to head (d8d875d) 89.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   89.52%   89.52%   -0.01%     
==========================================
  Files         115      115              
  Lines        9394     9393       -1     
  Branches     1499     1499              
==========================================
- Hits         8410     8409       -1     
  Misses        781      781              
  Partials      203      203              
Flag Coverage Δ
python3.10 88.71% <100.00%> (-0.01%) ⬇️
python3.11 88.71% <100.00%> (-0.01%) ⬇️
python3.12 88.71% <100.00%> (-0.01%) ⬇️
python3.8 88.80% <100.00%> (-0.01%) ⬇️
python3.9 89.06% <100.00%> (-0.01%) ⬇️
rust 90.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
shared/celery_config.py 100.00% <100.00%> (ø)
shared/utils/enums.py 100.00% <ø> (ø)

Impacted file tree graph

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1afb5ad) 91.54% compared to head (d8d875d) 91.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   91.54%   91.54%   -0.01%     
==========================================
  Files         122      122              
  Lines        9415     9414       -1     
  Branches     1613     1613              
==========================================
- Hits         8619     8618       -1     
  Misses        781      781              
  Partials       15       15              
Flag Coverage Δ
python3.10 88.71% <100.00%> (-0.01%) ⬇️
python3.11 88.71% <100.00%> (-0.01%) ⬇️
python3.12 88.71% <100.00%> (-0.01%) ⬇️
python3.8 88.80% <100.00%> (-0.01%) ⬇️
python3.9 89.06% <100.00%> (-0.01%) ⬇️
rust 90.20% <ø> (ø)
smart-labels 91.70% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrian-codecov adrian-codecov merged commit 55c9af2 into main Feb 8, 2024
26 checks passed
@adrian-codecov adrian-codecov deleted the 682-2-rename-save-commit-measurements-task-name branch February 8, 2024 19:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants