Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: {ta, test results}_finisher tasks #1062

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

joseph-sentry
Copy link
Contributor

they were previously trying to call
self.schedule_new_user_activated_task, which didn't exist on either of those tasks

they were previously trying to call
self.schedule_new_user_activated_task, which didn't exist on either
of those tasks
Copy link

sentry-io bot commented Feb 3, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: tasks/test_results_finisher.py

Function Unhandled Issue
process_impl_within_lock AttributeError: 'NoneType' object has no attribute 'pullid' app.tasks.test_results.TestResultsF...
Event Count: 35
process_impl_within_lock Plan.DoesNotExist: Plan matching query does not exist. app.tasks.test_results.TestResultsFinish...
Event Count: 11

Did you find this useful? React with a 👍 or 👎

@joseph-sentry joseph-sentry requested a review from a team February 3, 2025 19:04
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.52%. Comparing base (8d5485f) to head (f3986de).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/ta_finisher.py 50.00% 1 Missing ⚠️
tasks/test_results_finisher.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1062   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files         463      463           
  Lines       38073    38076    +3     
=======================================
+ Hits        37132    37135    +3     
  Misses        941      941           
Flag Coverage Δ
integration 42.84% <50.00%> (+<0.01%) ⬆️
unit 90.21% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

@codecov-notifications
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

github-actions bot commented Feb 3, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 66d2b33 Feb 5, 2025
24 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-schedule-new-user-activated-task branch February 5, 2025 14:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants