Skip to content

hover on image on the main page #205

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

Code-eat-sleep-include
Copy link

@Code-eat-sleep-include Code-eat-sleep-include commented May 23, 2024

Related Issue

Hover effect on image on the main page

Description

Better UI.

Type of PR

  • Feature enhancement

Screenshots / videos (if applicable)

image

Checklist:

  • [ X] I have performed a self-review of my code
  • [ X] I have read and followed the Contribution Guidelines.
  • [ X] I have tested the changes thoroughly before submitting this pull request.
  • [ X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ X] I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeharborhub-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 6:16pm

Copy link
Contributor

deepsource-io bot commented May 23, 2024

Here's the code health analysis summary for commits 4c097d2..be795cc. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@ajay-dhangar ajay-dhangar added enhancement New feature or request GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels gssoc GirlScript Summer of Code | Contributor labels May 23, 2024
@ajay-dhangar ajay-dhangar linked an issue May 23, 2024 that may be closed by this pull request
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can update and replace

previous code

.chh__header-image img {
  width: 100%;
  height: 100%;
  border-radius: 10% 40%;
}

New Code

.chh__header-image img {
  filter: drop-shadow(10px 10px 20px rgba(0, 0, 0, 0.6));
}

.chh__header-image img:hover {  
  filter: drop-shadow(10px 10px 20px rgba(169, 158, 158, 0.6));
}

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Code-eat-sleep-include
Copy link
Author

image
@ajay-dhangar Made the req. changes.

Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar ajay-dhangar merged commit 36b3e27 into codeharborhub:main May 23, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature Request: Hover effect on the image on the main page
2 participants