Skip to content

Call setter only after object has been populated #267

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2022
Merged

Call setter only after object has been populated #267

merged 1 commit into from
Dec 30, 2022

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Oct 21, 2022

This closes #266

@sonatype-lift
Copy link

sonatype-lift bot commented Oct 21, 2022

⚠️ 14 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@kwin kwin force-pushed the feature/call-setter-after-population branch from 2f03bad to f35c23a Compare October 23, 2022 10:14
@kwin kwin force-pushed the feature/call-setter-after-population branch from f35c23a to d6ea2d4 Compare October 23, 2022 10:17
@kwin kwin marked this pull request as ready for review December 29, 2022 10:19
@kwin kwin requested a review from michael-o December 29, 2022 14:10
@hboutemy hboutemy self-requested a review December 30, 2022 23:06
hboutemy
hboutemy approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hboutemy hboutemy merged commit c5ef5eb into codehaus-plexus:master Dec 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hboutemy hboutemy hboutemy approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

@michael-o michael-o Awaiting requested review from michael-o

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xpp3-reader: set method called before list is populated
3 participants
@kwin @hboutemy @slachiewicz