Skip to content

Remove ThreadBuildContext #51

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Conversation

laeubi
Copy link
Collaborator

@laeubi laeubi commented Oct 29, 2022

Fix #45

@olamy can you review?

@laeubi
Copy link
Collaborator Author

laeubi commented Oct 30, 2022

All checks passed, can this be merged?

@olamy olamy added the removed label Oct 30, 2022
@olamy
Copy link
Member

olamy commented Nov 5, 2022

All checks passed, can this be merged?

did you test this will maven plugins using the api?

@laeubi
Copy link
Collaborator Author

laeubi commented Nov 5, 2022

did you test this will maven plugins using the api?

I'm not aware of any use for the maven plugin, this is used in m2e on the implementation side, but as explained in #45 I don't think an API should ship "helpers" if the implementation could implement it itself.

@olamy
Copy link
Member

olamy commented Nov 5, 2022

@laeubi
Copy link
Collaborator Author

laeubi commented Nov 5, 2022

Both use it for testing purpose, one of the projects is archived. And for the later one I wonder why they do not register TestIncrementalBuildContext at first place and have the constructor parameter be threadlocals ...

@olamy
Copy link
Member

olamy commented Nov 5, 2022

All good for the (good :) ) answers!

@olamy olamy merged commit 46ce8d1 into codehaus-plexus:master Nov 5, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ThreadBuildContext
2 participants