-
Notifications
You must be signed in to change notification settings - Fork 3
Use a CachingOutputStream when using the build context #64
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@gnodet can you explain what will be the advantage here? |
It provides caching. The output file is not modified unless there's an actual change in the content. |
Maybe you can adjust the commit message to explain this as it is not really obvious (for me) so one can read about it later on. I must confess the name is a bit confusing because one usually more have caching for reading data. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but keep in mind that as of today no one is using the "new" build API here so a release might not have any impact on existing users.
Yes, PRs will follow... |
This won't help as this will instantly break the plugin, first m2e needs to add support for the new plexus-build API ... |
Plugins won't be broken, I think it's only the incremental build inside m2e which will be broken, and most probably, not really broken, but running sub-optimally (i.e. will rebuild more than needed) until m2e is update to support both. |
Well that's the purpose of the build-api if that is not working the plugin is (from user POV) broken... |
The CachingOutputStream provides a write cache so that the target file is only modified if there's a content change. If the data written exactly maps the existing content of the file, the file will not be modified at all.
No description provided.