Skip to content

eclipse compiler: set generated source dir even if no annotation processor is configured #139

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

mguillem
Copy link
Contributor

Synchronized with the javac compiler: https://github.com/codehaus-plexus/plexus-compiler/blob/master/plexus-compilers/plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavacCompiler.java#L269

For a multimodule maven project using the eclipse compiler, generated source files are currently created in the project root directory instead of the target/generated-(test-)sources of the submodule.

@mguillem mguillem changed the title set generated source dir even if no annotation processor is configured eclipse compiler: set generated source dir even if no annotation processor is configured Jun 17, 2021
@mguillem
Copy link
Contributor Author

Hi maintainers
can someone have a look at this PR? Thanks.

@mguillem
Copy link
Contributor Author

mguillem commented Jul 6, 2021

@olamy can you perhaps have a look at this PR? Thanks.

@olamy olamy added the bug label Jul 8, 2021
@mguillem
Copy link
Contributor Author

mguillem commented Jul 9, 2021

Builds are failing only with 17-ea, zulu. Is it possible that it has nothing to do with this PR?

@mguillem
Copy link
Contributor Author

mguillem commented Aug 9, 2021

@olamy could you provide some feedback about what I can do for this issue?

@olamy olamy merged commit be7ebc6 into codehaus-plexus:master Aug 10, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants