Skip to content
This repository was archived by the owner on Dec 4, 2024. It is now read-only.

Fixed sort order of descriptor xml files for reproducible build #28

Closed
wants to merge 1 commit into from
Closed

Fixed sort order of descriptor xml files for reproducible build #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...mponent-metadata/src/main/java/org/codehaus/plexus/metadata/DefaultMetadataGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.io.FileOutputStream;
import java.io.OutputStreamWriter;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.Comparator;
Expand Down Expand Up @@ -148,7 +149,18 @@ public int compare( ComponentDescriptor d1, ComponentDescriptor d2 )
{
File[] files = request.componentDescriptorDirectory.listFiles();

for ( File file : files )
// Sort the descriptor files by name to make the output reproducible
List<File> sortedFiles = new ArrayList<File>( Arrays.asList( files) );
Collections.sort( sortedFiles, new Comparator<File>()
{
public int compare( File f1, File f2 )
{
return f1.getName().compareTo( f2.getName() );
}
});


for ( File file : sortedFiles )
{
if ( file.getName().endsWith( ".xml" ) && !file.getName().equals( "plexus.xml" ) )
{
Expand Down