Fix symbolic links to directories are not recognized as directories #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had regression in which symlinks to directories are no longer considered directories. Add assertion to ensure the behaviour is not changed in future.
plamentotev
changed the title
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
src/main/java/org/codehaus/plexus/components/io/attributes/FileAttributes.java
Show resolved
Hide resolved
|
As there are no objections I'll proceed and revert the change and make a new release. |
I'd rather fix the problem is possible. Let me investigate today. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is regression (#71) introduced with #33. The proposal is to revert #33 and make a new release of Plexus IO to fix the regression. Latter we can re-introduce the speed improvements, more carefully inspecting if they not change existing behavior. I've also added additional assertion to the existing tests that detects the regression.
Any objection?
cc @gnodet