Skip to content

Replace plexus-component-metadata plugin (deprecated) with Sisu #156

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

slachiewicz
Copy link
Member

No description provided.

@slawekjaranowski
Copy link
Member

Do all plexus project use JSR-330 components instead plexus-annotatnios?
Maybe in first step add sisu and add enforcer rule with warning that project use plexus-annotation

@slachiewicz
Copy link
Member Author

I don't think so,. But with parent upgrade in subprojects we can add explicitly version

@slachiewicz
Copy link
Member Author

Do all plexus project use JSR-330 components instead plexus-annotatnios? Maybe in first step add sisu and add enforcer rule with warning that project use plexus-annotation

https://github.com/apache/maven/blob/maven-3.9.x/maven-core/src/main/java/org/apache/maven/DefaultMaven.java#L66

and still everything in maven-compat use Plexus annotations - and agreed to not touch it

@slachiewicz slachiewicz marked this pull request as draft May 3, 2023 15:30
@slachiewicz
Copy link
Member Author

I'll wait with this change until next pom release

@slachiewicz slachiewicz marked this pull request as ready for review May 16, 2023 17:35
@slachiewicz slachiewicz force-pushed the replace-metadata-with-sisu branch from 8dc0c6f to dcca8d6 Compare May 16, 2023 18:50
@slachiewicz slachiewicz marked this pull request as draft July 5, 2023 12:09
@slachiewicz slachiewicz force-pushed the replace-metadata-with-sisu branch from dcca8d6 to 8d1eb8f Compare July 13, 2023 16:32
@slachiewicz slachiewicz marked this pull request as ready for review October 2, 2023 15:32
@slachiewicz slachiewicz added dependencies Pull requests that update a dependency file maintenance labels Oct 2, 2023
@slachiewicz slachiewicz merged commit 403a9d9 into master Oct 3, 2023
@slachiewicz slachiewicz deleted the replace-metadata-with-sisu branch October 3, 2023 07:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants