Skip to content

Fix SCM URLs #98

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Fix SCM URLs #98

merged 1 commit into from
Feb 13, 2025

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Feb 13, 2025

Use proper SSH URL for developerConnection, use HTTPs for regular connection

<tag>HEAD</tag>
<url>https://github.com/codehaus-plexus/plexus-sec-dispatcher.git</url>
<connection>scm:git:https://github.com/codehaus-plexus/plexus-sec-dispatcher.git</connection>
<developerConnection>scm:git:ssh://git@github.com:codehaus-plexus/plexus-sec-dispatcher.git</developerConnection>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use SSH or HTTPs authentication here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see https in more of plexus project

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it work with SSH as before, as HTTPS is meh. I have same issue on ASF projects as well, HTTPS gitbox keeps asking me for username and pw, unlike when using SSH.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some concerns in the past regarding blocked SSH ports. For me there is a fundamental difference between Gitbox and GitHub: The former allows to use your regular credentials, the latter requires a PAT.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to change start from - parent pom .... mixed can have impact of relative path calculation by site plugin 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer the case with an upcoming version of maven-site-plugin: apache/maven-site-plugin#227

@@ -16,11 +16,12 @@
<description>This library provides encryption/decryption functionality with pluggable ciphers and password providers</description>

<scm>
<connection>scm:git:git@github.com:codehaus-plexus/plexus-sec-dispatcher.git</connection>
<developerConnection>scm:git:git@github.com:codehaus-plexus/plexus-sec-dispatcher.git</developerConnection>
<tag>HEAD</tag>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HEAD is ok value here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 3d4acb7.

Use proper SSH URL for developerConnection, use HTTPs for regular
connection
@kwin kwin merged commit 9d2fc90 into master Feb 13, 2025
17 checks passed
@kwin kwin deleted the fix-scm-url branch February 13, 2025 15:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants