-
Notifications
You must be signed in to change notification settings - Fork 4
Fix SCM URLs #98
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix SCM URLs #98
Conversation
<tag>HEAD</tag> | ||
<url>https://github.com/codehaus-plexus/plexus-sec-dispatcher.git</url> | ||
<connection>scm:git:https://github.com/codehaus-plexus/plexus-sec-dispatcher.git</connection> | ||
<developerConnection>scm:git:ssh://git@github.com:codehaus-plexus/plexus-sec-dispatcher.git</developerConnection> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use SSH or HTTPs authentication here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see https
in more of plexus project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is IMHO a hassle with GitHub as it requires using PAT (https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/about-authentication-to-github#https).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it work with SSH as before, as HTTPS is meh. I have same issue on ASF projects as well, HTTPS gitbox keeps asking me for username and pw, unlike when using SSH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some concerns in the past regarding blocked SSH ports. For me there is a fundamental difference between Gitbox and GitHub: The former allows to use your regular credentials, the latter requires a PAT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to change start from - parent pom .... mixed can have impact of relative path calculation by site plugin 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer the case with an upcoming version of maven-site-plugin: apache/maven-site-plugin#227
@@ -16,11 +16,12 @@ | |||
<description>This library provides encryption/decryption functionality with pluggable ciphers and password providers</description> | |||
|
|||
<scm> | |||
<connection>scm:git:git@github.com:codehaus-plexus/plexus-sec-dispatcher.git</connection> | |||
<developerConnection>scm:git:git@github.com:codehaus-plexus/plexus-sec-dispatcher.git</developerConnection> | |||
<tag>HEAD</tag> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HEAD is ok value here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 3d4acb7.
Use proper SSH URL for developerConnection, use HTTPs for regular connection
Use proper SSH URL for developerConnection, use HTTPs for regular connection