Skip to content

NIO-7: Potential performance gains using offloading #91

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

mkarg
Copy link
Collaborator

@mkarg mkarg commented Aug 16, 2020

This PR proposed the use of NIO-7 functionality to benefit from potential performance gains thanks to offloading to lower levels (JVM-internal solutions, OS-internal solutions, FS-internal solutions, etc.) instead of old-school File API.

mkarg added 2 commits August 16, 2020 14:35
Provides potentially better performance.

Signed-off-by: Markus KARG <markus@headcrashing.eu>
Provides potentially better performance.

Signed-off-by: Markus KARG <markus@headcrashing.eu>
@mkarg
Copy link
Collaborator Author

mkarg commented Aug 16, 2020

@rfscholte @hboutemy @olamy @bimargulies @khmarbaise Please review this PR. I would be glad if you would adopt this performance improvement. :-)

@mkarg
Copy link
Collaborator Author

mkarg commented Sep 5, 2020

What do I have to do to trigger merging?

@mkarg
Copy link
Collaborator Author

mkarg commented Dec 14, 2020

@olamy @gnodet @hboutemy @ezeeyahoo Why not merging this PR?

@mkarg
Copy link
Collaborator Author

mkarg commented Dec 14, 2020

@michael-o Thank you for the additional approval, but what is the process for actually merging the PR?

@michael-o
Copy link
Member

Pushing the merge button.

@michael-o michael-o merged commit ad1a668 into codehaus-plexus:master Dec 14, 2020
@mkarg mkarg deleted the NIO-7 branch December 14, 2020 12:28
@mkarg
Copy link
Collaborator Author

mkarg commented Dec 14, 2020

Pushing the merge button.

The button is not enabled for me. Seems I am missing the needed rights. What do I have to do to obtain them for the next time?

@michael-o
Copy link
Member

Pushing the merge button.

The button is not enabled for me. Seems I am missing the needed rights. What do I have to do to obtain them for the next time?

I was referring to myself or other project committers ;-)

@mkarg
Copy link
Collaborator Author

mkarg commented Dec 14, 2020

Pushing the merge button.

The button is not enabled for me. Seems I am missing the needed rights. What do I have to do to obtain them for the next time?

I was referring to myself or other project committers ;-)

How can I become a committer? I always wait for months for reactions upon my PRs, and I would like to be a more agile member of the team.

@michael-o
Copy link
Member

I will try to add you. I have been contributing anyway in the last couple of years. But even if you are a committer we still prefer PRs for peer reviews.

@mkarg
Copy link
Collaborator Author

mkarg commented Dec 14, 2020

I will try to add you. I have been contributing anyway in the last couple of years. But even if you are a committer we still prefer PRs for peer reviews.

Thanks for adding me. Sure I will still file PRs for reviews, but in the end I can click merge three months earlier. ;-)

@mkarg mkarg self-assigned this Dec 23, 2020
@mkarg mkarg added this to the 3.4.0 milestone Dec 23, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants