Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Duplicated classes org.codehaus.plexus.util.xml.Xpp3Dom and org.codehaus.plexus.util.xml.Xpp3DomBuilder from maven-xml-impl #17

Closed
tmortagne opened this issue May 23, 2023 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@tmortagne
Copy link

I just tried to upgrade to plexus-utils 4 which means adding plexus-xml as dependency here and there, but I had the surprise to notice that both plexus-xml and its direct dependency maven-xml-impl contain 2 classes with the same name and extremely similar code. I was wondering if this is really on purpose since it's not very clean.

I checked Xpp3Dom source and both versions seems very similar, the only changes I noticed are on the final static constants.

@slachiewicz slachiewicz added the bug Something isn't working label May 31, 2023
@elharo
Copy link

elharo commented Jun 23, 2023

same package name too?

@tmortagne
Copy link
Author

Yes, same package name too.

@elharo
Copy link

elharo commented Jun 24, 2023

I don't see that in the maven-xml-impl source code. Is it getting shaded into the jar somehow? Can you please post the command and output that leads you to believe that these classes are in maven-xml-impl?

@tmortagne
Copy link
Author

Can you please post the command and output that leads you to believe that these classes are in maven-xml-impl?

You can see that simply by opening the maven-xml-impl JAR from https://repo1.maven.org/maven2/org/apache/maven/maven-xml-impl/4.0.0-alpha-5/maven-xml-impl-4.0.0-alpha-5.jar for example.

@slachiewicz
Copy link
Member

maven-xml-impl depends on plexus-xml that depends on maven-xml-impl - kind of circle

image

@slachiewicz
Copy link
Member

2nd Xpp3Dom come from transitive dependency to old plexus-utils 3.x

@gnodet gnodet closed this as completed in c3d99b4 Jul 3, 2023
@gnodet gnodet added this to the 4.0.2 milestone Jul 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants