Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: use ::class keyword in config() #748

Merged
merged 1 commit into from
May 22, 2023
Merged

refactor: use ::class keyword in config() #748

merged 1 commit into from
May 22, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 19, 2023

No description provided.

@datamweb datamweb added the refactor Pull requests that refactor code label May 20, 2023
@datamweb
Copy link
Collaborator

datamweb commented May 22, 2023 •
edited
Loading

Sorry @kenjis , I didn't approve this PR to avoid new trouble(resolve conflicts) for contributor #744 .
please rebase.

@kenjis kenjis force-pushed the refactor-use-class-in-config branch from d3b5bf9 to bee838a Compare May 22, 2023 01:34
@kenjis
Copy link
Member Author

kenjis commented May 22, 2023

Rebased.

datamweb
datamweb approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenjis kenjis merged commit 736a88f into codeigniter4:develop May 22, 2023
@kenjis kenjis deleted the refactor-use-class-in-config branch May 22, 2023 02:17
@jozefrebjak jozefrebjak mentioned this pull request Jul 3, 2023
Closed
@kenjis kenjis restored the refactor-use-class-in-config branch July 5, 2023 11:13
@kenjis kenjis mentioned this pull request Jul 5, 2023
Merged
@kenjis kenjis deleted the refactor-use-class-in-config branch August 24, 2023 07:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @paulbalandan