Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix $DOCKER_USER to use cp and not mv and only convert once #2056

Closed
nhooyr opened this issue Sep 3, 2020 · 2 comments
Closed

Fix $DOCKER_USER to use cp and not mv and only convert once #2056

nhooyr opened this issue Sep 3, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Sep 3, 2020

See #2051
@nhooyr nhooyr added the bug Something isn't working label Sep 3, 2020
nhooyr added a commit that referenced this issue Sep 3, 2020
@nhooyr
docker: Fix $DOCKER_USER
d59723f 
Now we cp instead of mv $HOME as mv will fail due to the
user not existing.

We also only try to convert if the user hasn't been changed.

Finally I added usage to the docker docs in install.md

Closes #2056
@nhooyr nhooyr mentioned this issue Sep 3, 2020
Merged
nhooyr added a commit that referenced this issue Sep 3, 2020
@nhooyr
docker: Fix $DOCKER_USER
d48e55d 
Now we cp instead of mv $HOME as mv will fail due to the
user not existing.

We also only try to convert if the user hasn't been changed.

Finally I added usage to the docker docs in install.md

Closes #2056
nhooyr added a commit that referenced this issue Sep 3, 2020
@nhooyr
docker: Fix $DOCKER_USER
4e2acab 
We do not try renaming $HOME anymore as there is no good way
to do it.

We also only try to convert if the user hasn't been changed.

Finally I added usage to the docker docs in install.md

Closes #2056
nhooyr added a commit that referenced this issue Sep 3, 2020
@nhooyr
docker: Fix $DOCKER_USER (#2057)
9fb318c 
We do not try renaming $HOME anymore as there is no good way
to do it.

We also only try to convert if the user hasn't been changed.

Finally I added usage to the docker docs in install.md

Closes #2056
@sr229
Copy link
Contributor

sr229 commented Sep 6, 2020

This is actually a bit trickier, if I remember my time with OpenShift, we can actually do that however, the shell script that is responsible for doing that has the username string fixed. I think we can try porting the user hack from Theia for OpenShift.

@nhooyr
Copy link
Contributor Author

nhooyr commented Oct 6, 2020

This is fixed by #2057

@nhooyr nhooyr closed this as completed Oct 6, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhooyr @sr229