Skip to content

feat(testing): add code coverage #2621

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 22, 2021

This solution made possible thanks to @code-asher

  • refactor jest setup to play nicely with TS + lib/vscode
  • add code coverage support
  • add code coverage badge in readme

image

@jsjoeio jsjoeio requested a review from code-asher January 22, 2021 17:27
@jsjoeio jsjoeio self-assigned this Jan 22, 2021
@jsjoeio jsjoeio marked this pull request as draft January 22, 2021 17:30
@jsjoeio jsjoeio force-pushed the issue-2550-add-coverage branch 3 times, most recently from ea14f81 to 73a8fda Compare January 22, 2021 17:44
@@ -37,7 +37,6 @@
"@types/http-proxy": "^1.17.4",
"@types/js-yaml": "^3.12.3",
"@types/node": "^12.12.7",
"@types/node-fetch": "^2.5.7",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to ./test/package.json.

@@ -15,7 +15,7 @@
"sourceMap": true,
"tsBuildInfoFile": "./.cache/tsbuildinfo",
"incremental": true,
"typeRoots": ["./node_modules/@types", "./typings"],
"typeRoots": ["./node_modules/@types", "./typings", "./test/node_modules/@types"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsjoeio jsjoeio marked this pull request as ready for review January 22, 2021 17:45
@jsjoeio jsjoeio force-pushed the issue-2550-add-coverage branch 2 times, most recently from 7b1b3d5 to d00dc17 Compare January 22, 2021 20:49
@jsjoeio jsjoeio force-pushed the issue-2550-add-coverage branch from d00dc17 to 05beccf Compare January 22, 2021 21:18
@jsjoeio jsjoeio force-pushed the issue-2550-add-coverage branch from c5b820f to ac127f6 Compare January 25, 2021 18:14
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jsjoeio jsjoeio merged commit bdb8b0e into issue-2550-migrate-mocha-jest Jan 25, 2021
@jsjoeio jsjoeio deleted the issue-2550-add-coverage branch January 25, 2021 19:34
@jsjoeio jsjoeio added the testing Anything related to testing label May 14, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants