feat: add more tests for proxy.ts #3858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3858 +/- ##
==========================================
+ Coverage 63.40% 63.51% +0.10%
==========================================
Files 36 36
Lines 1872 1872
Branches 379 379
==========================================
+ Hits 1187 1189 +2
+ Misses 582 580 -2
Partials 103 103
Continue to review full report at Codecov.
|
|
cc @code-asher would love to get your eyes on this and help me understand what I'm missing |
greyscaled
reviewed
Jul 27, 2021
jsjoeio
force-pushed
the
jsjoeio-add-proxy-test
branch
from
1655625 to
a86f3df
Compare
jsjoeio
commented
Jul 27, 2021
jsjoeio
force-pushed
the
jsjoeio-add-proxy-test
branch
from
8390c7c to
9eca6a5
Compare
greyscaled
reviewed
Jul 27, 2021
jsjoeio
force-pushed
the
jsjoeio-add-proxy-test
branch
from
9eca6a5 to
07f6647
Compare
greyscaled
approved these changes
Jul 29, 2021
jsjoeio
force-pushed
the
jsjoeio-add-proxy-test
branch
from
07f6647 to
9137816
Compare
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more tests for
proxy.ts, specifically to test that our proxy handles error events appropriately.Fixes N/A
P.S. huge shoutout to @vapurrmaid for pairing with me on this 🎉