Skip to content

chore: add configuration for Semantic Pull Requests app #4652

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Dec 19, 2021

Configuration for the Semantic Pull Requests app. Feel free to push to my branch to make any edits.

@jawnsy jawnsy requested review from jsjoeio and greyscaled December 19, 2021 00:26
@jawnsy jawnsy self-assigned this Dec 19, 2021
@jawnsy jawnsy requested a review from a team December 19, 2021 00:26
@github-actions
Copy link

github-actions bot commented Dec 19, 2021

✨ Coder.com for PR #4652 deployed! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #4652 (5713508) into main (70c91c8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4652   +/-   ##
=======================================
  Coverage   69.23%   69.23%           
=======================================
  Files          29       29           
  Lines        1638     1638           
  Branches      341      341           
=======================================
  Hits         1134     1134           
  Misses        428      428           
  Partials       76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70c91c8...5713508. Read the comment docs.

Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts. I think @coder/code-server-reviewers should figure out best usage. I can only really lend a perspective based on use in other repositories.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @jawnsy! Left some feedback. Happy to take on and push forward when I get back into the office if you want

@jsjoeio jsjoeio added this to the 4.0.2 milestone Jan 7, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 7, 2022

@jawnsy do you have interest in addressing the changes here or do you want me to finish this?

@jawnsy jawnsy force-pushed the jawnsy/chore-semantic-pr branch from e1c8eaa to 0519e28 Compare January 10, 2022 20:34
@jawnsy jawnsy temporarily deployed to CI January 10, 2022 20:34 Inactive
@jawnsy jawnsy requested a review from jsjoeio January 10, 2022 20:35
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @jawnsy 🎉

@jawnsy jawnsy force-pushed the jawnsy/chore-semantic-pr branch from a925640 to 5713508 Compare January 10, 2022 21:11
@jawnsy jawnsy temporarily deployed to CI January 10, 2022 21:11 Inactive
@jsjoeio jsjoeio merged commit ad81a30 into main Jan 10, 2022
@jsjoeio jsjoeio deleted the jawnsy/chore-semantic-pr branch January 10, 2022 22:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants