Skip to content

revert: @node-rs/argon2 -> node-argon2 #4829

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Feb 4, 2022

This reverts part of the changes introduced in refactor: migrate from argon2 ->
@node-rs/argon2 (#4733)

Switching to @node-rs/argon2 introduced bugs that we couldn't solve due to
limitations in npm.

see here
#4804 (comment)

Fixes #4804

This reverts part of the changes introduced in refactor: migrate from argon2 ->
@node-rs/argon2 (#4733)

Switching to @node-rs/argon2 introduced bugs that we couldn't solve due to
limitations in npm.

see here
#4804 (comment)
@jsjoeio jsjoeio requested a review from a team February 4, 2022 21:44
@jsjoeio jsjoeio self-assigned this Feb 4, 2022
@jsjoeio jsjoeio temporarily deployed to CI February 4, 2022 21:44 Inactive
@jsjoeio jsjoeio changed the title revert: partial revert of 723469ab5bed3ba9fbb3e8d5ecbfcd9a3bee2d88 revert: @node-rs/argon2 -> node-argon2 Feb 4, 2022
@jsjoeio jsjoeio temporarily deployed to npm February 4, 2022 21:53 Inactive
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #4829 (58308c8) into main (00224fa) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4829      +/-   ##
==========================================
- Coverage   69.25%   69.17%   -0.08%     
==========================================
  Files          29       29              
  Lines        1649     1645       -4     
  Branches      363      363              
==========================================
- Hits         1142     1138       -4     
  Misses        430      430              
  Partials       77       77              
Impacted Files Coverage Δ
src/node/util.ts 81.66% <100.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00224fa...58308c8. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

✨ Coder.com for PR #4829 deployed! It will be updated on every commit.

@jsjoeio jsjoeio temporarily deployed to CI February 4, 2022 22:25 Inactive
@jsjoeio jsjoeio merged commit 25b1340 into main Feb 4, 2022
@jsjoeio jsjoeio deleted the jsjoeio-revert-argon2-2 branch February 4, 2022 22:52
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
* revert: partial revert of 723469a

This reverts part of the changes introduced in refactor: migrate from argon2 ->
@node-rs/argon2 (coder#4733)

Switching to @node-rs/argon2 introduced bugs that we couldn't solve due to
limitations in npm.

see here
coder#4804 (comment)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot find module '@node-rs/argon2-linux-arm64-gnu'
2 participants