Skip to content

fix: patch telemetry #5158

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2022
Merged

fix: patch telemetry #5158

merged 2 commits into from
May 4, 2022

Conversation

code-asher
Copy link
Member

This seems to have been dropped in the rewrite.

@code-asher
fix: patch telemetry
304ae2d 
This seems to have been dropped in the rewrite.
@code-asher code-asher requested a review from a team May 4, 2022 22:22
jsjoeio
jsjoeio suggested changes May 4, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in your console.log 😉

@codecov
Copy link

codecov bot commented May 4, 2022 •
edited
Loading

Codecov Report

Merging #5158 (3f4262e) into main (7027ec7) will not change coverage.
The diff coverage is n/a.

❗ Current head 3f4262e differs from pull request most recent head 11447aa. Consider uploading reports for the commit 11447aa to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5158   +/-   ##
=======================================
  Coverage   71.62%   71.62%           
=======================================
  Files          30       30           
  Lines        1688     1688           
  Branches      375      375           
=======================================
  Hits         1209     1209           
  Misses        410      410           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7027ec7...11447aa. Read the comment docs.

@code-asher code-asher requested a review from jsjoeio May 4, 2022 22:56
jsjoeio
jsjoeio approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jsjoeio jsjoeio added this to the April 2022 milestone May 4, 2022
@code-asher code-asher merged commit ef0d76b into coder:main May 4, 2022
@code-asher code-asher deleted the telemetry branch May 4, 2022 23:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@code-asher @jsjoeio