Skip to content

refactor: use npm in build steps and postinstall.sh #5844

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2022
Merged

refactor: use npm in build steps and postinstall.sh #5844

merged 3 commits into from
Dec 7, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Dec 7, 2022

  • refactor: default to npm in postinstall.sh
  • refactor: exclude yarn.lock in standalone

@jsjoeio
refactor: default to npm in postinstall.sh
62bf7c8 
yarn has a bug where it will try to update dependencies even if
`yarn.lock` is present. Therefore we're defaulting to `npm` to prevent
further issues.
@jsjoeio
refactor: exclude yarn.lock in standalone
8e12975 
By excluding `yarn.lock`, we prevent issues where the user must use
`yarn` instead of `npm` to install code-server.
@jsjoeio jsjoeio changed the title jsjoeio/fix build issue refactor: use npm in build steps and postinstall.sh Dec 7, 2022
@jsjoeio jsjoeio self-assigned this Dec 7, 2022
@jsjoeio jsjoeio temporarily deployed to npm December 7, 2022 20:39 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Dec 7, 2022 •
edited
Loading

Codecov Report

Merging #5844 (f2137c0) into main (df49838) will increase coverage by 2.27%.
The diff coverage is 40.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5844      +/-   ##
==========================================
+ Coverage   72.66%   74.94%   +2.27%     
==========================================
  Files          30       30              
  Lines        1683     1688       +5     
  Branches      370      371       +1     
==========================================
+ Hits         1223     1265      +42     
+ Misses        397      361      -36     
+ Partials       63       62       -1
Impacted Files Coverage Δ
src/node/routes/index.ts 78.64% <25.00%> (-2.17%) ⬇️
src/node/wrapper.ts 25.62% <100.00%> (+25.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1297e9a...f2137c0. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 7, 2022 •
edited
Loading

✨ code-server dev build published to npm for PR #5844!

  • Last publish status: success
  • Commit: f2137c0

To install in a local project, run:

npm install @coder/code-server-pr@5844

To install globally, run:

npm install -g @coder/code-server-pr@5844

@jsjoeio jsjoeio temporarily deployed to npm December 7, 2022 20:56 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 7, 2022 21:01 — with GitHub Actions Inactive
@jsjoeio jsjoeio marked this pull request as ready for review December 7, 2022 22:04
@jsjoeio jsjoeio requested a review from a team as a code owner December 7, 2022 22:04
@jsjoeio jsjoeio merged commit 3182be6 into main Dec 7, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-build-issue branch December 7, 2022 22:04
@jsjoeio jsjoeio added this to the December 2022 milestone Dec 7, 2022
@jsjoeio jsjoeio mentioned this pull request Dec 7, 2022
Closed
4 tasks
@jsjoeio jsjoeio modified the milestones: December 2022, 4.9.1 Dec 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @code-asher