Skip to content

fix: dst path in nfpm #5875

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Dec 16, 2022
Merged

fix: dst path in nfpm #5875

merged 5 commits into from
Dec 16, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Dec 13, 2022

Found by @welove42 in #5810

Testing to see if this fixes the issue in releasing on Linux. See #5874

@jsjoeio jsjoeio self-assigned this Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #5875 (afc7a0e) into main (87f606d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5875   +/-   ##
=======================================
  Coverage   74.94%   74.94%           
=======================================
  Files          30       30           
  Lines        1688     1688           
  Branches      371      371           
=======================================
  Hits         1265     1265           
  Misses        361      361           
  Partials       62       62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f606d...afc7a0e. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm December 13, 2022 18:12 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Dec 13, 2022

✨ code-server dev build published to npm for PR #5875!

  • Last publish status: success
  • Commit: afc7a0e

To install in a local project, run:

npm install @coder/code-server-pr@5875

To install globally, run:

npm install -g @coder/code-server-pr@5875

@jsjoeio jsjoeio marked this pull request as ready for review December 13, 2022 19:05
@jsjoeio jsjoeio requested a review from a team as a code owner December 13, 2022 19:05
@jsjoeio jsjoeio added this to the December 2022 milestone Dec 13, 2022
ci/README.md Outdated
@@ -112,3 +112,5 @@ Helps avoid clobbering the CI configuration.
- Loads all images in `./release-images` and then builds and pushes a multi architecture
docker manifest for the amd64 and arm64 images to `codercom/code-server:$VERSION` and
`codercom/code-server:latest`.

hello world
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left over from testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol whoops. Nice catch!

@jsjoeio jsjoeio enabled auto-merge (squash) December 15, 2022 16:40
@jsjoeio jsjoeio disabled auto-merge December 15, 2022 16:40
@jsjoeio jsjoeio temporarily deployed to npm December 15, 2022 16:43 — with GitHub Actions Inactive
@jsjoeio jsjoeio modified the milestones: December 2022, 4.9.1 Dec 15, 2022
@jsjoeio jsjoeio temporarily deployed to npm December 15, 2022 21:28 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm December 16, 2022 15:58 — with GitHub Actions Inactive
@jsjoeio jsjoeio merged commit fa39d47 into main Dec 16, 2022
@jsjoeio jsjoeio deleted the jsjoeio/nfpm-fix branch December 16, 2022 18:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants