Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: url refresh after log out and log in #67

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

fioan89
Copy link
Collaborator

@fioan89 fioan89 commented Apr 3, 2025

  • the main env header page API is quite limiting, in the sense that the title is never allowed to change. Today we display the Coder URL as the title. However, if the user switches between two deployments via log out and then log in, the URL is never refreshed, leading to a confusing UI (URL is old, while workspaces are from the new deployment)

  • to workaround the issue we redesigned the page, to have a static string as the page, and bellow the first row, have a link field reflecting the new URL.

  • resolves Deployment URL is not refreshed after log out and login to another deployment #66

- the main env header page API is quite limiting, in the sense that the title is never allowed to change.
  Today we display the Coder URL as the title. However, if the user switches between two deployments by
  logging out and then logging in, the URL is never refreshed, leading to a confusing UI (URL is old,
  while workspaces are from the new deployment)
- to workaround the issue we redesigned the page, to have a static string as the page, and bellow the first
  row, have a link field reflecting the new URL.

 - resolves #66
@fioan89
Copy link
Collaborator Author

fioan89 commented Apr 3, 2025

The before vs after:
Screenshot 2025-04-04 at 00 36 00
Screenshot 2025-04-04 at 00 53 51

matifali
matifali previously approved these changes Apr 4, 2025
@matifali
Copy link
Member

matifali commented Apr 4, 2025

This doesn't look that good, but it looks like we don't have an option here
I am also fine without making this change, as few people switch between Coder deployments.

We can keep the issue open and wait till ToolBox provides a better way to handle this.

It's safe to label this as an upstream issue, too, given we don't have enough control over it.

@matifali matifali dismissed their stale review April 4, 2025 05:54

Stale

@fioan89 fioan89 marked this pull request as draft April 4, 2025 18:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment URL is not refreshed after log out and login to another deployment
2 participants