feat: build and publish multiarch image #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
commented
Jul 16, 2024
Comment on lines
-33
to
-45
| - name: Echo Go Cache Paths | ||
| id: go-cache-paths | ||
| run: | | ||
| echo "GOCACHE=$(go env GOCACHE)" >> ${{ runner.os == 'Windows' && '$env:' || '$' }}GITHUB_OUTPUT | ||
| echo "GOMODCACHE=$(go env GOMODCACHE)" >> ${{ runner.os == 'Windows' && '$env:' || '$' }}GITHUB_OUTPUT | ||
|
|
||
| - name: Go Build Cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ${{ steps.go-cache-paths.outputs.GOCACHE }} | ||
| key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.**', '**.go') }} | ||
|
|
||
| # Install Go! |
There was a problem hiding this comment.
setup-go has a built-in cache that works as expected.
Comment on lines
-24
to
-36
| - name: Echo Go Cache Paths | ||
| id: go-cache-paths | ||
| run: | | ||
| echo "GOCACHE=$(go env GOCACHE)" >> ${{ runner.os == 'Windows' && '$env:' || '$' }}GITHUB_OUTPUT | ||
| echo "GOMODCACHE=$(go env GOMODCACHE)" >> ${{ runner.os == 'Windows' && '$env:' || '$' }}GITHUB_OUTPUT | ||
|
|
||
| - name: Go Build Cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: ${{ steps.go-cache-paths.outputs.GOCACHE }} | ||
| key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.**', '**.go') }} | ||
|
|
||
| - uses: actions/setup-go@v5 |
There was a problem hiding this comment.
setup-go has a built-in cache that works as expected.
Comment on lines
-54
to
-62
| - name: Push Image | ||
| run: | | ||
| VERSION=$(./scripts/version.sh) | ||
| BASE=ghcr.io/coder/coder-logstream-kube | ||
| IMAGE=$BASE:$VERSION | ||
| docker tag coder-logstream-kube:latest $IMAGE | ||
| docker tag coder-logstream-kube:latest $BASE:latest | ||
| docker push $IMAGE | ||
| docker push $BASE:latest |
There was a problem hiding this comment.
moved pushing and building to the ./scripts/build.sh
scripts/build.sh
Outdated
Comment on lines
37
to
45
| # Build | ||
| if [ "$CI" = "false" ]; then | ||
| docker buildx build --platform linux/$current -t coder-logstream-kube --load . | ||
| else | ||
| VERSION=$(../scripts/version.sh) | ||
| BASE=ghcr.io/coder/coder-logstream-kube | ||
| IMAGE=$BASE:$VERSION | ||
| docker buildx build --platform linux/amd64,linux/arm64,linux/arm/v7 -t $IMAGE -t $BASE:latest --push. | ||
| fi |
There was a problem hiding this comment.
--load only works for single arch images, so it can not be used with a multi arch manifest. As a workaround, I split the local and CI build commands.
Locally, we only build for the current arch; in CI, we create a multi-arch image.
matifali
changed the title
matifali
requested review from
johnstcn
and removed request for
coadler and
deansheather
johnstcn
approved these changes
Jul 26, 2024
|
|
||
| ENTRYPOINT ["/coder-logstream-kube"] | ||
| FROM --platform=$BUILDPLATFORM scratch AS base | ||
| ARG TARGETARCH |
There was a problem hiding this comment.
reviewer note: this comes from --platform
ref: https://docs.docker.com/build/guide/multi-platform/#platform-build-arguments
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the release workflow to build and push a multi-arch image and simplifies the CI process. The changes include:
Supersedes #44
Closes #29