Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(docs): document build secrets #401

Merged
merged 11 commits into from
Nov 4, 2024
Merged

feat(docs): document build secrets #401

merged 11 commits into from
Nov 4, 2024

Conversation

SasSwart
Copy link
Contributor

@SasSwart SasSwart commented Oct 31, 2024

This PR provides documentation for envbuilder build secrets.
Documentation for how to use build secrets from Terraform in conjunction with Coder will be provided separately.

Note that the documentation refers to ghcr.io/coder/envbuilder:latest. That will only work once we release this and push build secret support to ghcr. For now, you can test this by building your own version of the envbuilder container and using that instead.

@SasSwart SasSwart requested review from johnstcn and mafredri November 1, 2024 06:08
@SasSwart SasSwart marked this pull request as ready for review November 1, 2024 11:33
@SasSwart SasSwart marked this pull request as draft November 1, 2024 13:37
@SasSwart SasSwart marked this pull request as ready for review November 4, 2024 07:51
@SasSwart SasSwart requested a review from johnstcn November 4, 2024 08:09
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for clarity 👍

@SasSwart SasSwart merged commit c16ae9f into main Nov 4, 2024
4 checks passed
@SasSwart SasSwart deleted the jjs/buildsecrets branch November 4, 2024 10:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants