Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(filebrowser): failed to set server_base_path if db is not existing #393

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

dstoffel
Copy link
Contributor

On the first start, the DB does not exist and the "filebrowser config set --baseurl" will failed. filebrowser was starting with the wrong baseurl (subdomain=false). it starts correctly on the second try if the db was persisted. this fix set the correct baseurl even if the db was not existing

On the first start, the DB do not exist and the "filebrowser config set --baseurl" will failed. filebrowser was starting with the wrong baseurl (subdomain=false). it starts correctly on the second try if the db was persisted. this fix set the correct baseurl even if the db was not existing
@matifali
Copy link
Member

matifali commented Jan 29, 2025

Thanks, @dstoffel, for the contribution. I have a few suggestions. Please also run bun fmt and bun test to ensure ci passes.

@matifali matifali changed the title bugfix: failed to set server_base_path if db is not existing fix(filebrowser): failed to set server_base_path if db is not existing Jan 30, 2025
@matifali
Copy link
Member

matifali commented Feb 4, 2025

@dstoffel, can you address the suggestion and make sure CI passes? Thanks again for your contribution.

dstoffel and others added 2 commits February 5, 2025 09:47
Co-authored-by: M Atif Ali <me@matifali.dev>
@dstoffel
Copy link
Contributor Author

dstoffel commented Feb 5, 2025

i cannot have bun working on my machine. I'm still having the issue :

error: Executable not found in $PATH: "terraform"
error: Executable not found in $PATH: "docker"

related issue: #389
according to this link, the issue is fixed in bun. (of course, terraform & docker are available in my path)

I'm using exactly the same version that the CI is using:

  • bun 1.2.2+c1708ea6a
  • typescript@5.5.4
  • bun-types@1.1.23
  • gray-matter@4.0.3
  • marked@12.0.2
  • prettier@3.3.3
  • prettier-plugin-sh@0.13.1
  • prettier-plugin-terraform-formatter@1.2.1

If i try with the same ci.yaml (github action) on my fork repo, i also have the same error: https://github.com/dstoffel/coder-modules/actions/runs/13154797963/job/36709410893

I don't understand how the test is going to the next step when it run inside your actions.
Do you have any advice ?

Thanks,
Davy

EDIT: just found #390 , i will try with this fix

@matifali matifali merged commit 22b2ad5 into coder:main Feb 6, 2025
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants