chore: hide flag completions by default #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
ammario
requested changes
Aug 21, 2024
| isSlice { | ||
| allResps = append(allResps, "--"+opt.Flag) | ||
| } | ||
| } |
There was a problem hiding this comment.
Try to minimize indentation — use an early return instead of the else block
ammario
approved these changes
Aug 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vast majority of shell completion scripts hide flag completions by default, only showing them if the current word starts with a
-.For example, all the fish completion scripts that ship with the shell itself do this, as do the
gitcompletions forzsh.Additionally, in some shells, completion results are also shown in an order where flags starting with
--are always displayed first, which is reasonably annoying.Thanks to maf for picking up on this!